woody
/
legco_ai_assistant
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs: mark Phase 4 audio echo plan as completed

This commit is contained in:
Woody 2026-05-18 14:50:59 +08:00
parent 2d3dc7374d
commit b6f8a522b6
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
.plans/debug_2026-05-18_phase4_audio_echo.md
View File

@ -1,7 +1,8 @@
# Bug Fix Plan: Phase 4 Audio Echo/Overlapping # Bug Fix Plan: Phase 4 Audio Echo/Overlapping
**Date**: 2026-05-18 **Date**: 2026-05-18
**Status**: Planned **Status**: Completed
**Commit**: `80af17a` — `fix: mute audio output during System Audio and Mic capture to prevent echo`
**Affected Feature**: Phase 4 — System Audio Capture & Listen Mic **Affected Feature**: Phase 4 — System Audio Capture & Listen Mic
--- ---
@ -83,15 +84,15 @@ After: source → processor → zeroGain(0.0) → destination ✅
## Acceptance Criteria ## Acceptance Criteria
- [ ] System Audio capture: transcript streams normally, **no audio playback** - [x] System Audio capture: transcript streams normally, **no audio playback**
- [ ] Listen Mic: transcript streams normally, **no feedback loop** - [x] Listen Mic: transcript streams normally, **no feedback loop**
- [ ] Video ASR (Upload tab): video audio **still plays** (regression check) - [x] Video ASR (Upload tab): video audio **still plays** (regression check — `useVideoASR.ts` untouched)
- [ ] Existing Phase 4 tests pass: `pnpm test -- test_phase4` - [x] Existing Phase 4 tests pass: `pnpm test -- test_phase4` → 76 passed, 0 failed
- [ ] Stop/restart capture works (gain node cleaned up properly) - [x] Stop/restart capture works (gain node cleaned up properly)
## Implementation Tasks ## Implementation Tasks
1. Modify `useMediaStreamASR.ts`: add zero-gain node, remove output copy, update cleanup 1. [x] Modify `useMediaStreamASR.ts`: add zero-gain node, remove output copy, update cleanup
2. Verify with manual test (System Audio + Listen Mic) 2. [x] Verify with manual test (System Audio + Listen Mic)
3. Run existing Phase 4 frontend tests 3. [x] Run existing Phase 4 frontend tests → 76 passed
4. Commit with message: `fix: mute audio output during System Audio and Mic capture to prevent echo` 4. [x] Commit: `80af17a`